Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @niklasberglund)

android/test/common/src/main/kotlin/net/mullvad/mullvadvpn/test/common/rule/ForgetAllVpnAppsInSettingsTestRule.kt line 28 at r3 (raw file):

            try {
                device.findObjectWithTimeout(By.text(FORGET_VPN_VPN_BUTTON_TEXT)).click()

Maybe I misunderstood something, but this means that it will always try to click on both possible texts?

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

android/test/common/src/main/kotlin/net/mullvad/mullvadvpn/test/common/rule/ForgetAllVpnAppsInSettingsTestRule.kt line 28 at r3 (raw file):

The idea is that it first attempts to click "Forget VPN" and "Forget", but if that fails it will instead click "Delete VPN profile" and "DELETE".

Reviewable status: complete! all files reviewed, all discussions resolved

android/test/common/src/main/kotlin/net/mullvad/mullvadvpn/test/common/rule/ForgetAllVpnAppsInSettingsTestRule.kt line 28 at r3 (raw file):

Right, I missed that it needs to click on the confirm button as well. My bad.

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved